Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for hex address in chain link #688

Merged
merged 41 commits into from
Dec 20, 2021
Merged

feat: add support for hex address in chain link #688

merged 41 commits into from
Dec 20, 2021

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Dec 7, 2021 •
edited
Loading

Description

Closes: #685

This PR is the implementation of #685. It extends the support to the hex address like ETH.

Note: Rename PR to add support for eth address since eth address is generated in the other way.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #688 (60f40f5) into master (1a22342) will decrease coverage by 5.13%.
The diff coverage is 59.79%.

❗ Current head 60f40f5 differs from pull request most recent head 9f8c160. Consider uploading reports for the commit 9f8c160 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   84.23%   79.10%   -5.14%     
==========================================
  Files          91       52      -39     
  Lines        6624     4201    -2423     
==========================================
- Hits         5580     3323    -2257     
+ Misses        833      711     -122     
+ Partials      211      167      -44
Impacted Files Coverage Δ
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/client/cli/cli_params.go 70.00% <ø> (ø)
x/profiles/client/cli/cli_relationships.go 75.51% <ø> (ø)
x/profiles/client/utils/utils.go 56.25% <ø> (ø)
x/profiles/keeper/alias_functions.go 90.47% <ø> (ø)
x/profiles/keeper/genesis.go 84.61% <ø> (ø)
x/profiles/keeper/invariants.go 100.00% <ø> (ø)
x/profiles/keeper/keeper_blocks.go 85.50% <ø> (ø)
x/profiles/keeper/keeper_chain_links.go 84.74% <ø> (ø)
x/profiles/keeper/keeper_dtag_transfers.go 89.09% <ø> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5cb41...9f8c160. Read the comment docs.

@dadamu dadamu changed the title feat: add support for hex address in chain link feat: add support for ethaddress in chain link Dec 9, 2021
@dadamu dadamu changed the title feat: add support for ethaddress in chain link feat: add support for eth address in chain link Dec 9, 2021
@dadamu dadamu force-pushed the paul/support-hex-address-chain-link branch from be8f2ae to c3d959d Compare December 9, 2021 08:50
@dadamu dadamu marked this pull request as ready for review December 9, 2021 09:10
leobragaz
leobragaz reviewed Dec 9, 2021
View reviewed changes
proto/desmos/profiles/v1beta1/models_chain_links.proto Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links_test.go Outdated Show resolved Hide resolved
dadamu and others added 8 commits December 10, 2021 11:10
@dadamu @leobragaz
Update proto/desmos/profiles/v1beta1/models_chain_links.proto
38f0bb5 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu @leobragaz
Update x/profiles/types/models_chain_links.go
62947af 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu @leobragaz
Update x/profiles/types/models_chain_links.go
d946c68 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu @leobragaz
Update x/profiles/types/models_chain_links.go
d4be22d 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu @leobragaz
Update x/profiles/types/models_chain_links.go
f1d7837 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu
Add lost tests
8b1fa03
@dadamu
Add spaced address test
03c40ee
@dadamu
Update changelog
e392738
dadamu and others added 3 commits December 13, 2021 16:35
@dadamu @leobragaz
Update proto/desmos/profiles/v1beta1/models_chain_links.proto
e677d13 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu @leobragaz
Update proto/desmos/profiles/v1beta1/models_chain_links.proto
bf5c129 
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
@dadamu
Apply suggestions
2afd707
leobragaz
leobragaz approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready now 👍

dadamu and others added 3 commits December 16, 2021 10:29
@dadamu @RiccardoM
Update x/profiles/types/models_chain_links.go
de49d17 
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu @RiccardoM
Update proto/desmos/profiles/v1beta1/models_chain_links.proto
ac2c218 
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu
Apply suggestions
54c3afb
@dadamu dadamu changed the title feat: add support for eth address in chain link feat: add support for hex address in chain link Dec 16, 2021
RiccardoM
RiccardoM approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes but otherwise LGTM

proto/desmos/profiles/v1beta1/models_chain_links.proto Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links_test.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links_test.go Outdated Show resolved Hide resolved
x/profiles/types/models_chain_links_test.go Outdated Show resolved Hide resolved
dadamu and others added 4 commits December 20, 2021 16:22
@dadamu @RiccardoM
Update x/profiles/types/models_chain_links_test.go
1dc6dea 
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu @RiccardoM
Update proto/desmos/profiles/v1beta1/models_chain_links.proto
be63ecb 
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu @RiccardoM
Update x/profiles/types/models_chain_links_test.go
ee6bb4b 
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu
Apply suggestions
60f40f5
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Dec 20, 2021
@mergify mergify bot merged commit 7e3ebc1 into master Dec 20, 2021
@mergify mergify bot deleted the paul/support-hex-address-chain-link branch December 20, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

@leobragaz leobragaz leobragaz approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for hex address in chain link
3 participants
@dadamu @RiccardoM @leobragaz